Fix symbol highlight when hovering function name#1890
Merged
andyleejordan merged 5 commits intoPowerShell:mainfrom Aug 15, 2022
Merged
Fix symbol highlight when hovering function name#1890andyleejordan merged 5 commits intoPowerShell:mainfrom
andyleejordan merged 5 commits intoPowerShell:mainfrom
Conversation
Contributor
Author
|
Edit: Also, in case someone was wondering: test were extended to search for function name in definitions as they are different AST type than references -> use different code. |
andyleejordan
approved these changes
Aug 15, 2022
Member
andyleejordan
left a comment
andyleejordan
left a comment
There was a problem hiding this comment.
Nice work, thank you! Just made some inline changes to correct an existing spelling error.
test/PowerShellEditorServices.Test/Services/Symbols/AstOperationsTests.cs
Outdated
Show resolved
Hide resolved
test/PowerShellEditorServices.Test/Services/Symbols/AstOperationsTests.cs
Outdated
Show resolved
Hide resolved
test/PowerShellEditorServices.Test/Services/Symbols/AstOperationsTests.cs
Outdated
Show resolved
Hide resolved
test/PowerShellEditorServices.Test/Services/Symbols/AstOperationsTests.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
🎉 Btw. just realized that I didn't add test for The old extent was very wrong (endline, but endcolumn=startcolumn + name length). 95% sure it didn't break anything, but just letting you know in case you have a list of known missing regression tests :) |
Member
|
I do indeed have that 😅 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes:
PR Context
Fix #1887
Fix #1888